Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service] Improve assertMetrics test function in service_test.go #7075

Open
moh-osman3 opened this issue Jan 30, 2023 · 0 comments
Open

[Service] Improve assertMetrics test function in service_test.go #7075

moh-osman3 opened this issue Jan 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@moh-osman3
Copy link
Contributor

This issue is to track feedback provided about improving the assertMetrics() test function in service_test.go . This improvement is needed after adding instrumentation for proctelemetry.ProcessMetrics using otel-go, which breaks assertMetrics() when the featuregate is enabled. Otel metrics do not include the service* resource attributes with every metric and instead only records these attributes once in the otel_target_info.

The suggested improvement is to validate the metric values as well (since checking labels won't be helpful in the Otel case) and have two versions of assertMetrics. These functions should be named something like assertOCMetrics and asserOtelMetrics

@moh-osman3 moh-osman3 added the bug Something isn't working label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant