Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Telemetry Solution Requires Global state #6407

Closed
cpheps opened this issue Oct 26, 2022 · 1 comment
Closed

Internal Telemetry Solution Requires Global state #6407

cpheps opened this issue Oct 26, 2022 · 1 comment

Comments

@cpheps
Copy link
Contributor

cpheps commented Oct 26, 2022

The current opencensus internal telemetry solution requires that some global state be kept in the process. This causes complex lifecycle management if a Collector instance in that process is stoped and a new one started. The global state must be cleared by the first instance shutting down and reinitiated by the second instance starting up. This also adds additional complexity in a config reload scenario where the Collector creates a new service but keeps the same telemetry instance.

The global state that I found seems to be related to the Metric Registry and Views that are registered here.

I'd like to open this for discussion on possible ways to make the internal telemetry solution feel more natural with the collector instance lifecycle.

@atoulme
Copy link
Contributor

atoulme commented Dec 19, 2023

We will retire the OpenCensus approach to embrace the Otel go SDK and use it moving forward. See #816 for reference and next steps. Using the go SDK addresses some of your concerns as no globals will be used. Closing as not planned.

@atoulme atoulme closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants