Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confmap/httpmapprovider] An Implementation of ConfigMapProvider for HTTP data source #5810

Closed
junhaoyu-aws opened this issue Aug 4, 2022 · 2 comments
Labels
area:config enhancement New feature or request

Comments

@junhaoyu-aws
Copy link
Contributor

Is your feature request related to a problem? Please describe.
No. I suggest this new feature to allow OTEL Collector the ability to load configuration for itself by fetching and reading config files returned by HTTP servers.

Describe the solution you'd like
Create a new folder httpprovider under confmap, with files provider.go and provider_test.go. For the provider.go, I in a way keep the same as what yaml/file/envproviders do, but need a HTTP client to send HTTP requests. For the provider_test.go, I did unit tests for multiple possible cases (Empty urls, invalid config files, non-exist config files, and so on).

Additional context
I've implemented the code for this feature. Passed both unit tests and integration tests.

Sponsor
@Aneurysm9

@mx-psi mx-psi added enhancement New feature or request area:config labels Aug 4, 2022
@bogdandrutu
Copy link
Member

I think this is great.

@bogdandrutu
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:config enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants