Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find the right place/name for current ParserProvider and relationship with ConfigSource #3924

Closed
Tracked by #4231
bogdandrutu opened this issue Aug 30, 2021 · 5 comments
Assignees

Comments

@bogdandrutu
Copy link
Member

Ideally these 2 interfaces should be just one, conceptually they provide parts of the configuration (or full configuration).

  1. The current path of the ParserProvider in service seems to be inconsistent with the rest of the configuration interfaces.
  2. Try to unify the interfaces.
@bogdandrutu bogdandrutu added this to the Milestone-core-rc-release milestone Aug 30, 2021
@alolita alolita added area:config release:required-for-ga Must be resolved before GA release labels Sep 2, 2021
@alolita
Copy link
Member

alolita commented Sep 2, 2021

@Aneurysm9 can you please take a look and file a PR :-)

@alolita alolita removed the release:required-for-ga Must be resolved before GA release label Sep 13, 2021
@codeboten
Copy link
Contributor

Is this still an issue, if so please update the title/description with more information and I'd be happy to help resolve it.

@tigrannajaryan
Copy link
Member

@codeboten this is definitely still necessary. See one possible desirable way to use the full-config provider and and value-config providers: #4190

I am also looking for feedback on #4190 from user experience perspective, if you have any thoughts.

Please let me know if you plan to take this, if not then I will see if I can find time to take it.

@alolita
Copy link
Member

alolita commented Nov 24, 2021

@codeboten can you work with @Aneurysm9 on this since he is looking at this and has been discussing with Bogdan.

@bogdandrutu bogdandrutu removed this from the core-release-v37 milestone Jan 18, 2022
@bogdandrutu
Copy link
Member Author

This is done, the name is consolidated as config.MapProvider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants