cicd: check-contrib fails during the release process

[codeboten]

The check-contrib step failed at release process during the v0.115.0 release with the following message:

running go generate ./... in ./extension/encoding/avrologencodingextension
running go generate ./... in ./extension/encoding/jaegerencodingextension
go: updates to go.mod needed; to update it:
	go mod tidy
make[3]: *** [Makefile:179: for-all] Error 1
make[3]: Leaving directory '/tmp/opentelemetry-collector-contrib'
make[2]: *** [Makefile:310: generate] Error 2
make[2]: Leaving directory '/tmp/opentelemetry-collector-contrib'
make[1]: *** [Makefile:281: generate-contrib] Error 2
make[1]: Leaving directory '/home/runner/work/opentelemetry-collector/opentelemetry-collector'
make: *** [Makefile:266: check-contrib] Error 2
Error: Process completed with exit code 2.

See logs here: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/12137529261/job/33840992749

[codeboten]

To unblock the release, this was reverted in https://github.com/open-telemetry/opentelemetry-collector/pull/11794/files

[codeboten]

The reason a tidy needs to be run is that there are modules that pull in dependencies from collector-contrib (for example jaegerencodingextension) that need to be updated once their dependency (ie. internal/core) is update in the contrib repo. it's unclear why internal/core updates its versions since it's using a replace statement.

[jade-guiton-dd]

@codeboten I'm not sure I understand your explanation. go mod tidy is run just before make generate, so are you saying go mod tidy needs to be run twice in a row for this module? Unfortunately, using core from before the revert and the latest contrib main, I can't reproduce the error locally, so I'm not sure how to investigate this.

Update: It sounds like go mod tidy may indeed need to be run multiple times because of inter-dependencies inside contrib.

[mowies]

/label ci-cd

[jade-guiton-dd]

Update on this issue:

I added a subcommand to crosslink which generates a list of modules to tidy, in the appropriate order and with the appropriate repetitions to ensure(?) no modules are left in the "updates to go.mod needed" state at the end.

My plan is to do a release of the go-build-tools repo, then open a PR on contrib so it uses this command when tidying. That should hopefully fix this issue (and other issues related to incomplete tidies in contrib). Once done, I'll open a PR to unrevert #11670.