[service] fix bug with inconsistent resources #11578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tracer and logger provider were instantiating different resources objects that didn't have a `service.instance.id` attribute. This change fixes that by instantiating the SDK in the service and passing it to the factory via the telemetry.Settings struct. This also removes the duplicate code to instantiate the SDK multiple times, which will be useful when we move to instantiating MeterProvider via the config SDK. This bug is blocking the change to bump up the dependency on the config package. There are a few alternatives that were considered: 1. could set the resource's service.instance.id on the config object instead. this seemed messy as it would be editing the config struct and the instantiation of the SDK would remain duplicated. 2. update the factory to pass in a resource object option, i didn't want to update the NewFactory func. 3. update the CreateLogger, CreateTracerProvider to receive either a resource or sdk parameter, both of those seemed incorrect as well. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11578 +/- ##
=======================================
Coverage ? 91.51%
=======================================
Files ? 441
Lines ? 23919
Branches ? 0
=======================================
Hits ? 21889
Misses ? 1652
Partials ? 378 ☔ View full report in Codecov by Sentry. |
TylerHelmuth
approved these changes
Oct 30, 2024
Signed-off-by: Alex Boten <[email protected]>
songy23
approved these changes
Oct 31, 2024
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
The tracer and logger provider were instantiating different resources objects that didn't have a `service.instance.id` attribute. This change fixes that by instantiating the SDK in the service and passing it to the factory via the telemetry.Settings struct. This also removes the duplicate code to instantiate the SDK multiple times, which will be useful when we move to instantiating MeterProvider via the config SDK. This bug is blocking the change to bump up the dependency on the config package. There are a few alternatives that were considered: 1. could set the resource's service.instance.id on the config object instead. this seemed messy as it would be editing the config struct and the instantiation of the SDK would remain duplicated. 2. update the factory to pass in a resource object option, i didn't want to update the NewFactory func. 3. update the CreateLogger, CreateTracerProvider to receive either a resource or sdk parameter, both of those seemed incorrect as well. --------- Signed-off-by: Alex Boten <[email protected]>
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
The tracer and logger provider were instantiating different resources objects that didn't have a `service.instance.id` attribute. This change fixes that by instantiating the SDK in the service and passing it to the factory via the telemetry.Settings struct. This also removes the duplicate code to instantiate the SDK multiple times, which will be useful when we move to instantiating MeterProvider via the config SDK. This bug is blocking the change to bump up the dependency on the config package. There are a few alternatives that were considered: 1. could set the resource's service.instance.id on the config object instead. this seemed messy as it would be editing the config struct and the instantiation of the SDK would remain duplicated. 2. update the factory to pass in a resource object option, i didn't want to update the NewFactory func. 3. update the CreateLogger, CreateTracerProvider to receive either a resource or sdk parameter, both of those seemed incorrect as well. --------- Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tracer and logger provider were instantiating different resources objects that didn't have a
service.instance.idattribute. This change fixes that by instantiating the SDK in the service and passing it to the factory via the telemetry.Settings struct.This also removes the duplicate code to instantiate the SDK multiple times, which will be useful when we move to instantiating MeterProvider via the config SDK. This bug is blocking the change to bump up the dependency on the config package.
There are a few alternatives that were considered: