Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdatagen: generates code that's missing a dependency #10969

Closed
codeboten opened this issue Aug 27, 2024 · 0 comments · Fixed by #10970
Closed

mdatagen: generates code that's missing a dependency #10969

codeboten opened this issue Aug 27, 2024 · 0 comments · Fixed by #10970
Assignees
@codeboten
Labels
bug Something isn't working cmd/mdatagen release:blocker The issue must be resolved before cutting the next release

Comments

@codeboten
Copy link
Contributor

The groupsbyattr and filter processors are missing the "go.opentelemetry.io/otel/metric" import in the code that mdatagen generates for them. This causes an issue as go fmt will then try to pull in the dependency and it pulls in "go.opentelemetry.io/otel/sdk/metric" dependency instead of "go.opentelemetry.io/otel/metric"
@codeboten codeboten added bug Something isn't working release:blocker The issue must be resolved before cutting the next release labels Aug 27, 2024
@codeboten codeboten self-assigned this Aug 27, 2024
@codeboten codeboten mentioned this issue Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
bug Something isn't working cmd/mdatagen release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mdatagen] fix a missing import in a generated test file codeboten/opentelemetry-collector
1 participant
@codeboten