From e67cd8b10080a1172993fec038df1d4b0c9db15d Mon Sep 17 00:00:00 2001 From: Antoine Toulme Date: Fri, 22 Dec 2023 09:30:00 -0800 Subject: [PATCH] [chore] remove fieldalignment linter TODO (#9174) **Description:** Removes a TODO for the fieldalignment linter, offering a reasoning to keep it disabled moving forward. **Link to tracking Issue:** Fixes #2789 --- .golangci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 30c69ed9444..90d7a1b51c2 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -70,8 +70,11 @@ linters-settings: - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf enable-all: true - # TODO: Enable this and fix the alignment issues. disable: + # We want to order fields according to readability and grouping them by use cases. + # This linter does not offer a discernible performance improvement as the structs + # defined in this repository are not in the execution hot path. + # See https://github.com/open-telemetry/opentelemetry-collector/issues/2789 - fieldalignment revive: