RPM packages are missing a /bin/sh dependency

[shawnbutts]

/bin/sh is required for the postinstall.sh and other scripts.

Adding a Requires: for all dependencies needed during install is a common standard.

[jpkrohling]

Can you give more details about it? Is this happening for specific versions of specific distributions? I believe I installed the RPM a few times, and I'm confident it worked on Fedora 36.

[shawnbutts]

It most likely works in your testing because, the /bin/sh dependency is already in place. But, in an environment where it is not yet there (kickstart, etc) the install will fail in the PREIN step.

If there requirement is explicitly included, then RPM resolver can order the package installs correctly.

[jpkrohling]

Makes total sense. Are you able to open a PR fixing it? It's very likely here:

opentelemetry-collector-releases/cmd/goreleaser/internal/configure.go

Lines 106 to 139 in 26c3f34

	return config.NFPM{
	ID: dist,
	Builds: []string{dist},
	Formats: []string{"apk", "deb", "rpm"},
	License: "Apache 2.0",
	Description: fmt.Sprintf("OpenTelemetry Collector - %s", dist),
	Maintainer: "The OpenTelemetry Collector maintainers <[email protected]>",
	NFPMOverridables: config.NFPMOverridables{
	PackageName: dist,
	Scripts: config.NFPMScripts{
	PreInstall: path.Join("distributions", dist, "preinstall.sh"),
	PostInstall: path.Join("distributions", dist, "postinstall.sh"),
	PreRemove: path.Join("distributions", dist, "preremove.sh"),
	},
	Contents: files.Contents{
	{
	Source: path.Join("distributions", dist, fmt.Sprintf("%s.service", dist)),
	Destination: path.Join("/lib", "systemd", "system", fmt.Sprintf("%s.service", dist)),
	},
	{
	Source: path.Join("distributions", dist, fmt.Sprintf("%s.conf", dist)),
	Destination: path.Join("/etc", dist, fmt.Sprintf("%s.conf", dist)),
	Type: "config|noreplace",
	},
	{
	Source: path.Join("configs", fmt.Sprintf("%s.yaml", dist)),
	Destination: path.Join("/etc", dist, "config.yaml"),
	Type: "config",
	},
	},
	},
	}

Here's the relevant documentation from goreleaser: https://goreleaser.com/customization/nfpm/

[shawnbutts]

Sorry, I'm not familiar enough with the project or GoReleaser to do a PR at the moment.