[processor/metricsgeneration] Fix panic when using a sum metric for calculations #35428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/metricsgeneration
crobert-1
commented
Sep 25, 2024
dmitryax
reviewed
Sep 25, 2024
crobert-1
commented
Sep 25, 2024
...tricsreceiver/internal/scraper/filesystemscraper/internal/metadata/generated_metrics_test.go
Outdated
Show resolved
Hide resolved
…r/internal/metadata/generated_metrics_test.go
crobert-1
commented
Sep 27, 2024
dmitryax
approved these changes
Sep 30, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…alculations (open-telemetry#35428) **Description:** The metrics generation processor would previously hit a panic when the calculation rule was operating on a `sum` metric, instead of a `gauge`. The [component proposal](open-telemetry#2722), [initial implementation](open-telemetry#3433), nor the [README](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/metricsgenerationprocessor) state that it's a requirement for the metric to be a `gauge`, nor do I think this requirement makes sense. I've updated the logic to account for sum metrics being used and added a test. **Testing:** Added a test for this situation, the test panics before the change and passes after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The metrics generation processor would previously hit a panic when the calculation rule was operating on a
summetric, instead of agauge. The component proposal, initial implementation, nor the README state that it's a requirement for the metric to be agauge, nor do I think this requirement makes sense.I've updated the logic to account for sum metrics being used and added a test.
Testing:
Added a test for this situation, the test panics before the change and passes after.