[processor/geoip] skip error if geo metadata is not found #35278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…etry#35278) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> If a provider does not found any associated metadata to the given IP, the processor will continue the processing instead of returning the error. Nonetheless, the error will be logged when debug telemetry level is enabled. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#35047 **Testing:** <Describe what testing was performed and which tests were added.> Add a testdata case for IP `1.2.3.5` which is not available in any of the providers (maxmind neither mocked provider) **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If a provider does not found any associated metadata to the given IP, the processor will continue the processing instead of returning the error. Nonetheless, the error will be logged when debug telemetry level is enabled.
Link to tracking Issue: #35047
Testing: Add a testdata case for IP
1.2.3.5which is not available in any of the providers (maxmind neither mocked provider)Documentation: