-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some data couldn't be associated with k8s metadata when the agent was just started. #32556
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I wonder if we could add something to the processor's start function that waits for the kube client connections to be made. |
I think it's not enough to only wait for connections. If the connections are just made but metadata hasn't been synced yet, data won't be associated still. We need to wait for an initial complete sync like the implementation in #32622. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Oh noo |
…ibutes processor. (open-telemetry#32622) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> When starting `k8sattributes` processor, block until an initial synchronization has been completed. This solves open-telemetry#32556 **Link to tracking Issue:** <Issue number if applicable> fix open-telemetry#32556 **Testing:** <Describe what testing was performed and which tests were added.> Tested in a cluster with constant high span traffic, no more spans with unassociated k8s metadata after adding this pr. **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Christos Markou <[email protected]>
…ibutes processor. (open-telemetry#32622) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> When starting `k8sattributes` processor, block until an initial synchronization has been completed. This solves open-telemetry#32556 **Link to tracking Issue:** <Issue number if applicable> fix open-telemetry#32556 **Testing:** <Describe what testing was performed and which tests were added.> Tested in a cluster with constant high span traffic, no more spans with unassociated k8s metadata after adding this pr. **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Christos Markou <[email protected]>
Component(s)
processor/k8sattributes
What happened?
Description
When the agent is first started, the k8s metadata has not been fully synchronized by the k8sattributes processor. If any data passes through the component at this point, they will not be associated with metadata.
Steps to Reproduce
Expected Result
All data should be associated with k8s metadata.
Actual Result
There may be a little data that hasn't be assosicated.
Collector version
v0.95.0
Environment information
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
I think it's the best solution to wait for an initial sync when starting k8sattributes processor.
Or we can block data util an initial sync is finished.
The text was updated successfully, but these errors were encountered: