Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/jaegarremotesamplingextension/internal] add goleak tests for jaegerremotesampling extension #31661

Merged

Conversation

iblancasa
Copy link
Contributor

@iblancasa iblancasa commented Mar 8, 2024

Related to #30438
Resolves #31157

@crobert-1
Copy link
Member

Can you also add this to your PR description:

Resolves #31157

I'd actually filed a bug for this one specifically 👍

@iblancasa
Copy link
Contributor Author

Can you also add this to your PR description:

Resolves #31157

I'd actually filed a bug for this one specifically 👍

Didn't notice about this one. Thanks!

@iblancasa iblancasa changed the title [chore] add goleak tests for jaegerremotesampling extension [extension/jaegarremotesamplingextension/internal] add goleak tests for jaegerremotesampling extension Mar 11, 2024
@iblancasa iblancasa marked this pull request as ready for review March 11, 2024 18:48
@iblancasa iblancasa requested review from a team and codeboten March 11, 2024 18:48
Signed-off-by: Israel Blancas <[email protected]>
@iblancasa iblancasa force-pushed the goleak_jaegerremotesamplingextension branch from 1cd4ca3 to f2b945f Compare March 21, 2024 17:38
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@dmitryax dmitryax merged commit 101b8b1 into open-telemetry:main Mar 27, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 27, 2024
@iblancasa iblancasa deleted the goleak_jaegerremotesamplingextension branch March 27, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[extension/jaegarremotesamplingextension/internal] Leaking goroutine on shutdown
6 participants