From a197d7146c7e178cd5d235b2effd823a674812c2 Mon Sep 17 00:00:00 2001 From: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Date: Wed, 20 Dec 2023 15:28:39 -0700 Subject: [PATCH 1/2] Add getters to switch statement --- pkg/ottl/functions.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pkg/ottl/functions.go b/pkg/ottl/functions.go index 6a10b915efe3..bf7db8e55e32 100644 --- a/pkg/ottl/functions.go +++ b/pkg/ottl/functions.go @@ -454,6 +454,18 @@ func (p *Parser[K]) buildArg(argVal value, argType reflect.Type) (any, error) { return nil, err } return StandardTimeGetter[K]{Getter: arg.Get}, nil + case strings.HasPrefix(name, "BoolGetter"): + arg, err := p.newGetter(argVal) + if err != nil { + return nil, err + } + return StandardBoolGetter[K]{Getter: arg.Get}, nil + case strings.HasPrefix(name, "BoolLikeGetter"): + arg, err := p.newGetter(argVal) + if err != nil { + return nil, err + } + return StandardBoolLikeGetter[K]{Getter: arg.Get}, nil case name == "Enum": arg, err := p.enumParser((*EnumSymbol)(argVal.Enum)) if err != nil { From 2e31bc6e453f00835255f8b8a1ea1238d11ae0c9 Mon Sep 17 00:00:00 2001 From: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Date: Wed, 20 Dec 2023 15:32:19 -0700 Subject: [PATCH 2/2] changelog --- .../ottl-add-bool-getters-to-switch.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100755 .chloggen/ottl-add-bool-getters-to-switch.yaml diff --git a/.chloggen/ottl-add-bool-getters-to-switch.yaml b/.chloggen/ottl-add-bool-getters-to-switch.yaml new file mode 100755 index 000000000000..5880d36fa6cb --- /dev/null +++ b/.chloggen/ottl-add-bool-getters-to-switch.yaml @@ -0,0 +1,27 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: bug_fix + +# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) +component: pkg/ottl + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Fix bug where the Converter `IsBool` was not usable + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +issues: [30151] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# If your change doesn't affect end users or the exported elements of any package, +# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: []