-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdatagen] allow filtering out metrics based on resource attributes #29769
Conversation
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Good start. Thanks @povilasv! |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
eb09ac6
to
ddf037d
Compare
c2f625a
to
f001a93
Compare
Tested validation with:
Collector fails with:
So looks like the engine magically calls Validate() on the config 👍 |
e5e3078
to
2668ba5
Compare
84995e1
to
b8f9a6d
Compare
Thanks for reviewing @dmitryax , this is ready for the second round :) I played with this change in a kind cluster, and looks it does what we want :D |
I think |
I don't think we need to change |
74b6f9b
to
04733d9
Compare
0d7b9ec
to
5f895a2
Compare
188da45
to
a1f6e1a
Compare
@dmitryax Thanks for review! Updated based on your comments :) |
0fd59fe
to
38b06f9
Compare
38b06f9
to
e1fcf33
Compare
@povilasv PTAL at the failing CI |
@povilasv the PR looks good to me in general. Can you please submit if against mdatagen in core? |
Pushed a PR for core open-telemetry/opentelemetry-collector#9660 |
Closing this PR, as I added more tests and different packaging for the new filter package in the core repository. PR: open-telemetry/opentelemetry-collector#9660 I think we can review / merge the functionality after we fully deprecate the mdatagen in contrib. |
Description:
This PR allows filtering out metrics based on resource attributes. For example:
Would remove metrics that match regex or strict rules on resource attributes.
Link to tracking Issue:
#25134
Testing:
Documentation: