Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpAMP Agent Extension #16594
OpAMP Agent Extension #16594
Changes from 7 commits
df750c9
952cff6
185e8c3
27740ad
fc6beb3
c816932
9b4e0da
9a2619b
3437a4a
5d6b34b
c8a8c3e
029360a
48428d2
92f1488
859736d
c3ae9e6
390621e
3d6d560
1659320
924ed2d
fe2278d
9f86052
911382d
afce5a6
6f36984
8d78a13
a2f32ab
ee3e513
524bccc
5ea9924
cd17ed1
198e84d
0489a97
ca1d1d5
52d83f1
84f6ec2
1b17172
00d7b67
e5c5c64
72229c3
8743c3a
e84b7fd
096e856
db3530b
25e78ff
61492fb
572614a
ec237bc
30273a9
6f9b304
2b39482
05ec3a2
50c78af
d277c16
b581611
5ab82c2
c271773
8c86826
c6b3c39
a340f99
1f33f74
f3968e6
2d41a78
301b838
02ff11f
86351c5
2204190
c3aaddb
3688953
4555060
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to explore if we can use HTTPClientSettings here. That will give us the ability to specify a bunch of client-side settings (headers, TLS, auth, etc). I don't know though if it works with WebSocket.
It probably is not going to help much since we can't use HTTPClientSettings.ToClient() anyway (and that is the most useful part of HTTPClientSettings), unless we somehow modify the OpAMP Client implementation to accept a pre-built HTTP Client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tigrannajaryan I've experimented with https://github.com/SumoLogic/sumologic-otel-collector/blob/261043b945a4e69e73975cb3750f1b1d9f2c55c1/pkg/extension/opampextension/config.go#L26-L28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest using the
HTTPClientSettings
that way auth is provided for free.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
HTTPClientSettings
feels cumbersome and perhaps its going to be problematic.StartSettings
(https://github.com/open-telemetry/opamp-go/blob/main/client/types/startsettings.go#L11) has me doing things like: 924ed2d. Also, most of the settings will go unused, which could be confusing since they will pass validation.