Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Allow changing existing /unreleased/ files #12106

Merged
merged 1 commit into from
Jul 6, 2022
Merged

[CI] Allow changing existing /unreleased/ files #12106

merged 1 commit into from
Jul 6, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jul 6, 2022 •
edited
Loading

Sometimes it might be required to change or remove existing unreleased yaml files, for example to aggregate several existing changelog entries as done in #12105. CI should not fail in such scenarios.

@dmitryax
[CI] Allow changing existing /unreleased/ files
297ddca 
Sometimes it might be required to change or remove some existing unreleased yaml files. CI should not fail in such scenarios.
@dmitryax dmitryax requested review from a team and codeboten July 6, 2022 07:18
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 6, 2022
@dmitryax dmitryax mentioned this pull request Jul 6, 2022
Merged
@dmitryax
Copy link
Member Author

dmitryax commented Jul 6, 2022

@djaglowski PTAL

djaglowski
djaglowski approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected this to be rare enough that we'd just skip the check when necessary, but I don't feel strongly that this needs to be validated automatically.

@dmitryax dmitryax merged commit 122d0b0 into open-telemetry:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees

@codeboten codeboten

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitryax @jpkrohling @djaglowski @codeboten