Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split remote sampling feature from the Jaeger receiver #6510

Closed
5 tasks done
jpkrohling opened this issue Dec 3, 2021 · 6 comments
Closed
5 tasks done

Split remote sampling feature from the Jaeger receiver #6510

jpkrohling opened this issue Dec 3, 2021 · 6 comments
Labels
comp: extension comp:jaeger Jaeger related issues

Comments

@jpkrohling
Copy link
Member

jpkrohling commented Dec 3, 2021

As discussed during the latest GC call with @bogdandrutu, it could be beneficial to other components to split the remote sampling proxy from the Jaeger receiver into its own extension.

@jpkrohling
Copy link
Member Author

@frzifus, is there anything else pending on this?

@frzifus
Copy link
Member

frzifus commented Aug 25, 2022

I don't really think so. Just removing the components from the receiver in release v0.61.

Maybe registering the extention as a component? Is there a document that describes what exactly has to be done for this #13005 (comment)

@jpkrohling
Copy link
Member Author

jpkrohling commented Aug 25, 2022

Just this: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components

But it's missing the step to add the component to the manifests in the releases repository: https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml

Would you be open to sending a PR enhancing the contribution guidelines, and adding this last step?

@frzifus
Copy link
Member

frzifus commented Aug 25, 2022

sure, do i need to create an issue first or should i link it to this one?

@jpkrohling
Copy link
Member Author

Your choice. There's no need to have a dedicated issue for that, although I like to do it as it helps me keep track of my activities.

@frzifus
Copy link
Member

frzifus commented Sep 21, 2022

i think we can close that one too.
cc @jpkrohling

povilasv referenced this issue in coralogix/opentelemetry-collector-contrib Dec 19, 2022
* deprecate obsreport.Must functions in favor of obsreport.New

* add changelog

* fix lint

* split changelog in two

* Update .chloggen/return_error_for_obsreport_new_functions.yaml

Co-authored-by: Bogdan Drutu <[email protected]>

Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: extension comp:jaeger Jaeger related issues
Projects
None yet
Development

No branches or pull requests

2 participants