Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/k8scluster] Add phase datapoint attribute for k8s.pod.phase metric #36819

Open
yuri-rs opened this issue Dec 13, 2024 · 2 comments
Open
Labels
enhancement New feature or request receiver/k8scluster waiting-for:semantic-conventions Waiting on something on semantic-conventions to be stabilized

Comments

@yuri-rs
Copy link
Contributor

yuri-rs commented Dec 13, 2024

Component(s)

receiver/k8scluster

Is your feature request related to a problem? Please describe.

I'd like to use phase label selector for k8s.pod.phase metric. It is much more convinient and natural to use label filters.

Describe the solution you'd like

I would like to have phase=<Pending|Running|Succeeded|Failed|Unknown> label for k8s.pod.phase metric to be able to use it in queries, like:
k8s.pod.phase{phase="Failed"}

Describe alternatives you've considered

No response

Additional context

Please note that phase is emited as label in https://github.com/kubernetes/kube-state-metrics/blob/main/docs/metrics/workload/pod-metrics.md
See:
image

@yuri-rs yuri-rs added enhancement New feature or request needs triage New item requiring triage labels Dec 13, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@ChrsMark
Copy link
Member

That's the plan for modeling states, phases etc as part of open-telemetry/semantic-conventions#1032.

See the related open-telemetry/semantic-conventions#1668 and open-telemetry/semantic-conventions#1554.

@ChrsMark ChrsMark added waiting-for:semantic-conventions Waiting on something on semantic-conventions to be stabilized and removed needs triage New item requiring triage labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/k8scluster waiting-for:semantic-conventions Waiting on something on semantic-conventions to be stabilized
Projects
None yet
Development

No branches or pull requests

2 participants