Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose container healthcheck status in podmanreceivier #35826

Open
Markus78 opened this issue Oct 16, 2024 · 5 comments
Open

Expose container healthcheck status in podmanreceivier #35826

Markus78 opened this issue Oct 16, 2024 · 5 comments
Labels
enhancement New feature or request receiver/podman

Comments

@Markus78
Copy link

Component(s)

receiver/podman

Is your feature request related to a problem? Please describe.

Currently I cannot find healthcheck status in the attributes exported by the podman receiver , this is very useful for visualizing container status ( healthy or unhealthy )

Describe the solution you'd like

Add metric to make it possible to track if container healthcheck is healthy or unhealthy i.e

container.health.status

Describe alternatives you've considered

No response

Additional context

No response

@Markus78 Markus78 added enhancement New feature or request needs triage New item requiring triage labels Oct 16, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@rogercoll
Copy link
Contributor

@Markus78 Thanks for raising this issue.

I agree that a health attribute would be very helpful. My understanding is that we should try to have all new attributes and metrics in semantic conventions first, and quickly checking it seems we have no container.health attribute at the moment: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/attributes-registry/container.md

@Markus78
Copy link
Author

@rogercoll Thank you, Im slightly confused do I have to take any more action regarding the semantic conventions to move this along?

@rogercoll
Copy link
Contributor

That would be ideal, creating a PR into the semantic conventions repository will raise the attention of other contributors (and the repository maintainers) and we will ensure an agreement over the new container.health attribute. Later on, this attribute can be re-used among other OpenTelemetry components (e.g. docker, k8s receivers).

The PR to the podman's receiver does not need to wait for the semconv one to be merged, but it would be great to reference them to show up some real example of the attribute.

@Markus78
Copy link
Author

I wrote this issue

@atoulme atoulme removed the needs triage New item requiring triage label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/podman
Projects
None yet
Development

No branches or pull requests

3 participants