-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metric adjusters in prometheus receiver should have a better fallback strategy. #35188
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I'm supportive of that change. If you are interested, feel free to work on a PoC to see how much refactoring, etc. is needed to make that work |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I have the impression that this was solved already. I see something similar in the docs. |
Component(s)
receiver/prometheus
Is your feature request related to a problem? Please describe.
There are two metric adjusters in the Prometheus receiver:
start_timestamp
. There is a function gatereceiver.prometheusreceiver.UseCreatedMetric
, which, if enabled, will use*_created
so that thetimestamp
of the first sample will be used as a backup.use_start_time_metric
is set totrue
. It will take a metric representing the start time of the process and use it as thestart_timestamp
. If the metric is missing, an error is returned and all metrics are discarded.It seems odd that using
*_created
will fall back to using the first sample, but using the process start time will not fallback to anything.I have a number of targets to scrape, some of which have
*_created
metrics, others don't have*_created
but may haveprocess_start_time_seconds
. There is no way to optimally handle all these metrics with a unified configuration.Describe the solution you'd like
Allow to config a strategy like this:
*_created
.*_created
found, tryprocess_start_time_seconds
. (can be customized by settingstart_time_metric_regex
)Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: