[receiver/nginxreceiver] Add additional labels for nginxreceiver

[aofodo]

Component(s)

receiver/nginx

Is your feature request related to a problem? Please describe.

Metrics look like this

nginx_connections_current{__tenant_id__="default", state="active", tenant="default"} 255
nginx_connections_current{__tenant_id__="default", state="reading", tenant="default"} 0
nginx_connections_current{__tenant_id__="default", state="waiting", tenant="default"} 222
nginx_connections_current{__tenant_id__="default", state="writing", tenant="default"} 3

But in this example I am using 2 nginx. The metrics are summarized for both nginx. As a result, it looks like this on the graph

On the first nginx I have ~200, and on the second ~3 active connections.

Describe the solution you'd like

I suggest add additional labels in metrics with information about nginx endpoint. For example http_scheme, instance, net_host_name and net_host_port

Describe alternatives you've considered

No response

Additional context

Example of my collector configuration for 2 nginx:

receivers:
  nginx/first:
    endpoint: "http://first.nginx:9080"
    collection_interval: 60s
  nginx/second:
    endpoint: "http://second.nginx:9080"
    collection_interval: 60s

[github-actions]

Pinging code owners:

• receiver/nginx: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[djaglowski]

I'm not sure endpoint related information should be used as identifying attributes because they may be volatile. Are there any other identifiers available via the API? Perhaps a UUID of some sort?

[aofodo]

I'm not sure endpoint related information should be used as identifying attributes because they may be volatile. Are there any other identifiers available via the API? Perhaps a UUID of some sort?

There is no additional information from the API for identification. Maybe add an optional job_name: <string> to the nginxreceiver configuration for identification?

[djaglowski]

That's an interesting idea. If we want to do something along those lines I'd suggest we use the semantic conventions for service.*.

Config could look like:

receivers:
  nginx:
    ...
    service:
      name: foo
      instance.id: 627cc493-f310-47de-96bd-71410b7dec09

or maybe more generic:

receivers:
  nginx:
    ...
    additional_resource_attributes: # (probably a better name)
      service.name: foo
      service.instance.id: 627cc493-f310-47de-96bd-71410b7dec09
      custom.attribute: bar

@dmitryax, I think this issue could be relevant to many different metric scrapers. Do you think this is a reasonable solution we might want to use more broadly?

[crobert-1]

Removing needs triage as code owner has proposed a possible solution, with the understanding that specific implementation and configuration details may still need to be discussed.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/nginx: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[aofodo]

This is also relevant for receiver/kafkametricsreceiver

And his issue is still in demand

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/nginx: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.