-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/kafka]: Replace "topic" setting by "traces_topic", "logs_topic" and "metrics_topic" #32735
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Wouldn't defining 3 different receivers work here? receivers:
kafka/metrics:
topic: custom_metrics_topic
kafka/logs:
topic: custom_logs_topic
kafka/traces:
topic: custom_traces_topic
pipelines:
metrics:
receivers: [kafka/metrics]
logs:
receivers: [kafka/logs]
traces:
receivers: [kafka/traces] |
This works but this is inconsistent with the default behavior which allows using one receiver for three topics if you name your topics accordingly. |
Yeap, I think it makes sense to have more granular configuration options per signal. |
@ChrsMark I just opened a PR to make the change ^ |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Component(s)
receiver/kafka
Is your feature request related to a problem? Please describe.
When the setting "topic" is not specified, the same kafka receiver config can be used in all three pipelines if the topic names match the default values:
If the topic is set to any value, this structure will not work:
What happens in this case is that the three receivers will try to claim the same topic. This is a race condition that will succeed in 1/3 of scenarios.
To avoid this problem, the user must create three different configs for each pipeline. This is inconsistent with the default behavior that allows having one config for all three pipelines if the topic names are matching.
Describe the solution you'd like
The otlp receiver provides traces_url_path, metrics_url_path, and logs_url_path configuration to allow the URL paths that signal data needs to be sent to be modified per signal type.
The same principle can be applied to the topics of the kafka receiver:
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: