-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How should we handle imports of time/tzdata by dependencies? #32688
Comments
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
Component(s)
No response
Describe the issue you're reporting
This relates to discussion open-telemetry/opentelemetry-collector#9991, in which there seems to be consensus that we will follow the official guidance from
time/tzdata
which states:This package should normally be imported by a program's main package, not by a library. Libraries normally shouldn't decide whether to include the timezone database in a program.
As noted in #32506, we are currently pulling in a dependency in one of our components which imports the database. This effectively makes the decision for all of contrib that it will be included in the distro. I believe we should discourage this somehow.
Should we make a policy that components which import the database cannot be included in contrib?
The text was updated successfully, but these errors were encountered: