frequently prints startup error messages

[mike9421]

Component(s)

cmd/opampsupervisor

What happened?

Description

When I input incorrect OTEL configurations in the remote configuration, opampsupervisor frequently prints restart error messages instead of printing according to the restartTimer settings. As shown in the picture below:

Steps to Reproduce

1. Fill in the correct configuration to ensure that the opampsupervisor can connect to the backend normally
2. Start the backend OpAMP sample server
3. Start opampsupervisor
4. Providing incorrect remote configurations via the OpAMP UI.
5. View the stdout of opampsupervisor

Expected Result

Printing error messages according to the time set by the restartTimer.

Actual Result

Continuously printing error messages.

Collector version

all

Environment information

OS: Darwin
Compiler: go 1.21

OpenTelemetry Collector configuration

Any wrong configuration, for example:

exporters:
    logging: null
extensions:
    health_check:
        endpoint: 0.0.0.0:13133
receivers:
    otlp:
        protocols:
            https:
                endpoint: localhost:64509
service:
    extensions:
        - health_check
    pipelines:
        logs:
            exporters:
                - logging
            receivers:
                - otlp

Log output

2024-04-07T17:25:08.990+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.991+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.991+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.991+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.991+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.991+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.991+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.991+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.992+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.992+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.992+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.992+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.992+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.992+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.993+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.993+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.993+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.993+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.993+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}
2024-04-07T17:25:08.993+0800    DEBUG   supervisor/supervisor.go:758    Agent process exited unexpectedly. Will restart in a bit...     {"pid": 19071, "exit_code": 1}

Additional context

Frequently printing error messages is due to the problem of source code, which can be solved by changing it to c.doneCh <- struct{}{}.

But I don't know why to use close(c.doneCh), is there any other consideration?

[github-actions]

Pinging code owners:

• cmd/opampsupervisor: @evan-bradley @atoulme @tigrannajaryan

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[srikanthccv]

This is a duplicate of #27891. Will be fixed by #32150

[crobert-1]

Closing as duplicate, thanks for filing @mike9421!