Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/K8scluster] Add additional attributes to the k8s.container.restarts metric #31418

Closed
avanish-vaghela opened this issue Feb 26, 2024 · 5 comments

Comments

@avanish-vaghela
Copy link

Component(s)

receiver/k8scluster

Is your feature request related to a problem? Please describe.

Currently, the k8s.container.restarts metric does not include the metadata such as the reason for the restart and the exit code

Describe the solution you'd like

Add terminated_reason and exit_code attributes to the k8s.container.restarts metrics where appropriate

Describe alternatives you've considered

The current alternative is to use the Kube State Metrics's kube_pod_container_status_terminated_reason and kube_pod_container_status_last_terminated_exitcode metrics

Additional context

A related metric issue has been raised: #31282 (comment)

@avanish-vaghela avanish-vaghela added enhancement New feature or request needs triage New item requiring triage labels Feb 26, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@TylerHelmuth TylerHelmuth added priority:p2 Medium and removed needs triage New item requiring triage labels Feb 26, 2024
@TylerHelmuth
Copy link
Member

I like this attribute.

@avanish-vaghela
Copy link
Author

I will try and raise a draft PR

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 29, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants