Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify on CI that localhost featuregate changes are copied across repositories #30793

Closed
mx-psi opened this issue Jan 26, 2024 · 4 comments
Closed
Labels

Comments

@mx-psi
Copy link
Member

mx-psi commented Jan 26, 2024

          I'm wondering if there's a good way to enforce keeping this up to date `core`. There will be times they differ, but it should only be temporarily. There should be a PR opened for both repositories, one will just get merged before the other.

It could be a CI check that simply fails whenever a user changes the contents of these files, warning the user that core needs updated as well. A triager, approver, or maintainer could then come, confirm a PR is also opened against core, and then add some kind of skip label that ignores the check? Or just approve and merge it with the failing CI action knowing it's not an issue. If it's a CI action it would also need to be in core to make sure contrib stays up to date as well.

Otherwise we could add a CI action that simply compared file contents and fails when they don't match. This would be a bit more involved and would fail in unrelated PRs, which would be confusing.

I don't want to make it too complicated but speaking from experience, a comment at the top of a file is pretty easy to miss.

Originally posted by @crobert-1 in #30774 (comment)

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Mar 27, 2024
@mx-psi mx-psi removed the Stale label Mar 27, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label May 27, 2024
@mx-psi mx-psi removed the Stale label May 27, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jul 29, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants