Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions to tag PRs that need rebase #30493

Open
atoulme opened this issue Jan 12, 2024 · 6 comments
Open

Add github actions to tag PRs that need rebase #30493

atoulme opened this issue Jan 12, 2024 · 6 comments
Labels
ci-cd CI, CD, testing, build issues enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 12, 2024

Component(s)

No response

Describe the issue you're reporting

Consider adopting https://github.com/marketplace/actions/label-conflicting-pull-requests to run github actions on PRs to make sure we can tag PRs that need rebase, rather than having to go to each of them.

@atoulme atoulme added the needs triage New item requiring triage label Jan 12, 2024
@crobert-1 crobert-1 added the ci-cd CI, CD, testing, build issues label Jan 16, 2024
@crobert-1
Copy link
Member

Sounds like a good idea to me, it'd be really nice to have this enabled.

It looks like this specific action isn't widely used, and hasn't had a release for over a year, but perhaps it's just that there isn't anything more to do. Since it's CI/CD it's pretty easy to add and remove things like this, so if we do end up running into issues it's pretty easy to remove.

@crobert-1 crobert-1 added enhancement New feature or request and removed needs triage New item requiring triage labels Jan 16, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Mar 18, 2024
@crobert-1 crobert-1 removed the Stale label Mar 18, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label May 20, 2024
@crobert-1 crobert-1 added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels May 20, 2024
@mowies
Copy link
Member

mowies commented Jul 2, 2024

@crobert-1 since your last comment here, the action did get some updates. The latest release is currently 3 weeks old 👍🏼

I'd take this up, but I have some performance concerns. The action runs on push and synchronise events (i.e. whenever a PR is updated). I think that would generate huge CI/pipeline backlogs. Maybe running periodically makes sense but then again, I'm questioning the use of it.

@mowies
Copy link
Member

mowies commented Jul 2, 2024

Also, running on pull_request_target as suggested by the action, will be a security risk if not done correctly. Checking out the code in such a scenario opens you up to pwn requests.
But on the other hand, not having the pull_request_target makes the action useless, cus it's needed to be able to label PRs from forks.

@crobert-1
Copy link
Member

Good points @mowies, thanks for calling this out. This repo already has quite a large footprint in terms of running actions so it's good to consider impact before adding more actions.

Not sure the best path forward here, @atoulme do you have strong preferences one way or the other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Development

No branches or pull requests

3 participants