-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/stanza] file read status observability #30473
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I generally support the idea. I know there is some ongoing work to migrate the collector's internal telemetry to native otel instrumentation but we should be looking to define component-specific metrics in the near future. One thing to keep in mind when reporting metrics in terms of file paths is that in many cases file rotation will result in a time series being "reset". It's not immediately clear what the proper way to model this is, but as the consumer of a time series it would not necessarily be obvious what this means. For example: |
Pinging code owners for receiver/filelog: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Component(s)
pkg/stanza
Is your feature request related to a problem? Please describe.
We are adopting file log receiver largely for collecting logs and would like to see apart from checking registry file manually for the last read offset, trying to figure out the possibility to build this feature as part of stanza package or the receiver itself.
Describe the solution you'd like
If we are adding this, I think it could be metrics use case, for example, something like following with the file path as the metrics label(as long as the file is still a valid input source)
After checking the code, the best place for this is the Manager struct from the
fileconsumer
package as it has the info of file path and latest offset. One alternative I can think of is build something around the storage extension so when any offset/metadata is persisted via it, it can decode the data to get the offset, but this also means overhead on the decoding work.I appreciate all suggestions or comments.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: