Collect data from sidecars

[tzneal]

Component(s)

receiver/k8scluster

Is your feature request related to a problem? Please describe.

The Sidecars feature is enabled by default in Kubernetes 1.29 (https://kubernetes.io/blog/2023/08/25/native-sidecar-containers/). This receiver (and maybe more) should be updated to support them.

Describe the solution you'd like

This code only reports metrics from from containers in the pod. Sidecars are an init container with a restart policy of Always and run for the lifetime of the pod, so they should probably be reported here as well.

Describe alternatives you've considered

No response

Additional context

No response

[github-actions]

Pinging code owners:

• receiver/k8scluster: @dmitryax @TylerHelmuth @povilasv

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[bryan-aguilar]

I believe this could affect any component which collects pod request metrics. Such as https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/awscontainerinsightreceiver

I believe this is one of the important bits from the linked blog post on sidecar containers.

The resource usage calculation changes for the pod as restartable init container resources are now added to the sum of the resource requests by the main containers

We can also see that the k8s API changed the way in which Pod Requests are calculated due to sidecar containers.

https://github.com/kubernetes/kubernetes/blob/55f2bc10435160619d1ece8de49a1c0f8fcdf276/pkg/api/v1/resource/helpers.go#L88-L95

[github-actions]

Pinging code owners for receiver/awscontainerinsight: @Aneurysm9 @pxaws. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/awscontainerinsight: @Aneurysm9 @pxaws
• receiver/k8scluster: @dmitryax @TylerHelmuth @povilasv

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.