Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaegerreceiver,jaegerremotesampling]: thrift-gen, proto-gen featuregate does not work #27046

Closed
frzifus opened this issue Sep 21, 2023 · 4 comments
Assignees

Comments

@frzifus
Copy link
Member

frzifus commented Sep 21, 2023

Component(s)

extension/jaegerremotesampling, receiver/jaeger

What happened?

Description

See comment from @zcross #18485 (comment)

Steps to Reproduce

Run

./bin/otelcontribcol_linux_amd64 --config=config.yaml --feature-gates=+extension.jaegerremotesampling.replaceThriftWithProto

Expected Result

Using Proto-gen.

Actual Result

Flag has no effect.

Collector version

v0.85.0

Environment information

Environment

OS: Fedora Silverblue 38
Compiler(if manually compiled): go v1.21.0

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

See: open-telemetry/opentelemetry-collector#4967

@frzifus frzifus added the bug Something isn't working label Sep 21, 2023
@frzifus frzifus self-assigned this Sep 21, 2023
@github-actions
Copy link
Contributor

Pinging code owners for receiver/jaeger: @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@frzifus
Copy link
Member Author

frzifus commented Sep 21, 2023

Maybe once this issue (open-telemetry/opentelemetry-collector#8478) is fixed, we should reflect that in the changelog.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 21, 2023
@jpkrohling
Copy link
Member

@frzifus , that one seems to be merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants