Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prometheus Compliance Tests] - Incorrect workflow status during failure #26570

Closed
vasireddy99 opened this issue Sep 11, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues closed as inactive good first issue Good for newcomers Stale

Comments

@vasireddy99
Copy link
Contributor

vasireddy99 commented Sep 11, 2023

Description

The Prometheus compliance workflow are reporting incorrect status when the tests have a Failure,
reference. This will not help to identify which change has broke the tests.

Expected Result

The workflow should be shown as failure with error when tests are FAIL

Actual Result

The workflow is success when tests are FAIL

@vasireddy99 vasireddy99 added bug Something isn't working needs triage New item requiring triage labels Sep 11, 2023
@bryan-aguilar
Copy link
Contributor

The exit code of the step will be determined by this line

go test -v --tags=compliance -run "TestRemoteWrite/otel/.+" ./ |& tee ./test-report.txt

I am not familiar with the |& but what I assume this is giving an exit code 0 from the tee when we expect the exit code to be 1 from the go test. This behavior should be able to be replicated locally by running the above command and then checking exit code with echo $?.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • issue: Github issue template generation code needs this to generate the corresponding labels.

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 14, 2023
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues closed as inactive good first issue Good for newcomers Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants