Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make cloudflare receiver require TLS #26562

Closed
xbglowx opened this issue Sep 11, 2023 · 11 comments
Closed

Don't make cloudflare receiver require TLS #26562

xbglowx opened this issue Sep 11, 2023 · 11 comments
Labels

Comments

@xbglowx
Copy link
Contributor

xbglowx commented Sep 11, 2023

Component(s)

receiver/cloudflare

Is your feature request related to a problem? Please describe.

Trying to expose a cloudflare logpush endpoint using the cloudflare receiver and noticed that it is a requirement to configure TLS. This is not need in all setups, especially when the service is being hosted behind a LB or proxy that handles TLS

Describe the solution you'd like

Make TLS optional

Describe alternatives you've considered

No response

Additional context

No response

@xbglowx xbglowx added enhancement New feature or request needs triage New item requiring triage labels Sep 11, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski
Copy link
Member

@xbglowx, would you be willing to make a PR for this?

@xbglowx
Copy link
Contributor Author

xbglowx commented Sep 11, 2023

@xbglowx, would you be willing to make a PR for this?

I could try, but I am really rusty at golang. Any tips before I attempt to start on this?

@dehaansa
Copy link
Contributor

The cloudflare LogPush integration itself had a strict TLS requirement when this was implemented.

Do you have some evidence that LogPush no longer strictly required TLS?

@xbglowx
Copy link
Contributor Author

xbglowx commented Sep 11, 2023

The cloudflare LogPush integration itself had a strict TLS requirement when this was implemented.

Do you have some evidence that LogPush no longer strictly required TLS?

It still requires TLS, but if this receiver is sitting behind a proxy that handles TLS, do you also need this? For example, I am trying to run this on k8s and we already have TLS configured with cert-manager and Solo's Gloo VirtualService.

@dehaansa
Copy link
Contributor

It still requires TLS, but if this receiver is sitting behind a proxy that handles TLS, do you also need this? For example, I am trying to run this on k8s and we already have TLS configured with cert-manager and Solo's Gloo VirtualService.

I misunderstood your original question, I think that could most likely work.

@xbglowx
Copy link
Contributor Author

xbglowx commented Sep 11, 2023

Is there a slack channel that we can use, so that I can ask you some questions?

@xbglowx
Copy link
Contributor Author

xbglowx commented Sep 11, 2023

For the time being, I came up with #26629

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 13, 2023
@xbglowx
Copy link
Contributor Author

xbglowx commented Nov 13, 2023

Should be able to close this as fixed.

@github-actions github-actions bot removed the Stale label Nov 14, 2023
@djaglowski
Copy link
Member

Closed by #26629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants