-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new resourcedetection detector to extract k8s node UID #26538
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I think the k8sattributes processor already does something similar to this for pods and namespaces. From its README
Could this functionality be expanded to also set resource attributes from a nodes labels and annotations? Further question since I am not familiar with the k8sclusterreceiver. Do you want the node labels from which the metric data point originated from or from where the collector is running? |
Pinging code owners for processor/k8sattributes: @dmitryax @rmfitzpatrick @fatsheep9146 @TylerHelmuth. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Potentially, yes.
"from where the collector is running" for this issue. That's why we think the resource detection processor is the best place, as other detectors do similar work. We want to have "node labels from which the metric data point originated" -- this ask (when/if needed) would go to k8sattributes processor. So the collector can set this attribute in both agent and gateway modes when it's possible to deduct it from the existing k8s attributes or the client connection. |
Makes sense to me, thank you for the clarification. Sounds like this would fit in as an enhancement to the resource detection processor. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
processor/resourcedetection
Is your feature request related to a problem? Please describe.
[receiver/k8sclusterreceiver]
adds the attribute/dimensionk8s.node.uid
which has all the node labels added as properties and send it along a small set of metrics likek8s.node.condition_ready
We would like to expand the use of
k8s.node.uid
attribute/value and add it to all (or specific) metrics/logs/traces emitted by the collector so we can propagate and correlate the labels/properties in our backend.Describe the solution you'd like
Adding a detector to the resourcedetection that pull node specific metadata, in particular k8s.node.uid, would be the ideal solution
Describe alternatives you've considered
I have looked into
k8sattributes
processor, but it does not pull/expose labels from nodes.Moreover, I have considered expanding
k8sattributes
processor to add node labels to it, but after internal discussion, we realized thatk8sattributes
processor scope is cluster wide whereas the ask here is for metrics related to a specific node.Additional context
PR #26524
The text was updated successfully, but these errors were encountered: