Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signalfx exporter: add translation rules for cpu.utilization_per_core #2540

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Mar 3, 2021

Calculate cpu.utilization_per_core metric additionally to cpu.utilization. The metric is disabled by default.

@dmitryax dmitryax requested a review from a team March 3, 2021 06:39
@tigrannajaryan
Copy link
Member

Unit tests failed.

@dmitryax dmitryax force-pushed the sfx-exporter-cpu-per-core-translation branch from af698fb to e453775 Compare March 3, 2021 17:08
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #2540 (f783df3) into main (fa60029) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2540   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files         419      419           
  Lines       20981    20981           
=======================================
  Hits        19132    19132           
  Misses       1382     1382           
  Partials      467      467           
Flag Coverage Δ
integration 69.28% <ø> (+0.06%) ⬆️
unit 90.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa60029...f783df3. Read the comment docs.

@dmitryax
Copy link
Member Author

dmitryax commented Mar 3, 2021

Thanks @tigrannajaryan . Fixed

@tigrannajaryan
Copy link
Member

@dmitryax OK to merge?

Calculate `cpu.utilization_per_core` metric additionally to `cpu.utilization`. The metrics is disabled by default.
@dmitryax dmitryax force-pushed the sfx-exporter-cpu-per-core-translation branch from e453775 to f783df3 Compare March 3, 2021 19:31
@bogdandrutu bogdandrutu merged commit 2fc26c8 into open-telemetry:main Mar 3, 2021
This was referenced Mar 15, 2021
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
…#2540)

Calculate `cpu.utilization_per_core` metric additionally to `cpu.utilization`. The metrics is disabled by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants