newrelicexporter: multi-tenant support for sending trace data + perf enhancements #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrcventura
reviewed
Mar 1, 2021
Codecov Report
@@ Coverage Diff @@
## main #2481 +/- ##
==========================================
+ Coverage 91.06% 91.11% +0.04%
==========================================
Files 417 418 +1
Lines 20935 21013 +78
==========================================
+ Hits 19065 19145 +80
+ Misses 1407 1406 -1
+ Partials 463 462 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nrcventura
reviewed
Mar 2, 2021
Co-authored-by: Allan Feldman <[email protected]> Co-authored-by: Jack Berg <[email protected]> Co-authored-by: Chris Ventura <[email protected]>
This reverts commit c8c540f995e8aec571c0e5d51456ae27b41ffcc9.
a-feld
force-pushed
the
alanwest/newrelicexporter-perf-and-multi-tenant-support
branch
from
ab904a4 to
b96213a
Compare
Co-authored-by: Chris Ventura <[email protected]>
…porter-perf-and-multi-tenant-support
a-feld
approved these changes
Mar 3, 2021
bogdandrutu
approved these changes
Mar 4, 2021
alanwest
deleted the
alanwest/newrelicexporter-perf-and-multi-tenant-support
branch
This was referenced Mar 15, 2021
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
…enhancements (#2481) * Multi-tenant support for sending trace data + perf enhancements Co-authored-by: Allan Feldman <[email protected]> Co-authored-by: Jack Berg <[email protected]> Co-authored-by: Chris Ventura <[email protected]> * Add errors abstraction. * Fix SpansURLOverride usage * Clear your mind must be, if you are to fix lint errors! * Fix lint issues. * Update mock endpoint to use the same status as the real endpoint * Fix linting error in newrelic.go by using gofmt -s * Add license header to errors.go * Add environment variable allowing metric support to be disabled * Revert "Add environment variable allowing metric support to be disabled" This reverts commit c8c540f995e8aec571c0e5d51456ae27b41ffcc9. * Convert to host and insecure flags. * Fix formatting. * Default exporter config * Revert change to createMetricsExporter * Make insecure flags private. * Update newrelic-telemetry-sdk-go reference to v0.5.2 * go mod tidy * Add test coverage Co-authored-by: Chris Ventura <[email protected]> * Fix bad url test * go mod tidy * Update README * Revert go.sum Co-authored-by: Allan Feldman <[email protected]> Co-authored-by: Jack Berg <[email protected]> Co-authored-by: Chris Ventura <[email protected]>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Add section in docs for initializing a tracer * Apply suggestions from code review Co-authored-by: Anthony Mirabella <[email protected]> * Change weird incomplete sentence * update some of the bullets to be a tad less opinionated * Rename section so it's open to different ways to acquire a tracer * Remove guidance as it is orthogonal * Apply suggestions from code review Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIKeyHeaderconfig option enabling reading New Relic API key from request header.spans_url_overrideandmetrics_url_overridehas been renamed tospans_host_overrideandmetrics_host_overrideto reflect the fact that you only need to specifyhost[:port]when overriding these endpoints.newrelic-telemetry-sdk-gowhich includes a number of performance improvements.newrelic-telemetry-sdk-go.@a-feld @nrcventura @jack-berg