Counter64 not a supported type

[bobbled]

Component(s)

receiver/snmp

What happened?

Description

snmpreceiver does not support collecting counter64 values.

Steps to Reproduce

Attempt to collect counter64 values with snmpreceiver.

Expected Result

counter64 objects are handled as int's and passed through the pipeline.

Actual Result

counter64 objects are treated as unsupported types.

Collector version

0.80.0

Environment information

Environment

OS: Ubuntu 20.04 (kubernetes)

OpenTelemetry Collector configuration

receivers:
  snmp/test:
    endpoint: udp://10.1.1.1:161
    version: v2c
    community: public
    metrics:
      ipSystemStatsHCInReceives:
        unit: "By"
        sum:
          aggregation: cumulative
          monotonic: false
          value_type: int
        scalar_oids:
          - oid: "1.3.6.1.2.1.4.31.1.1.4.1"
exporters:
  logging:
    loglevel: debug
service:
  telemetry:
    logs:
      level: debug
  pipelines:
    metrics:
      receivers: [snmp/test]
      processors: []
      exporters: [logging]

Log output

2023-07-03T16:04:48.309Z    error    scraperhelper/scrapercontroller.go:213    Error scraping metrics    {"kind": "receiver", "name": "snmp/test", "data_type": "metrics", "error": "problem with getting scalar data: data for OID '.1.3.6.1.2.1.4.31.1.1.4.1' not a supported type", "scraper": "snmp"}
go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).scrapeMetricsAndReport
    go.opentelemetry.io/collector/[email protected]/scraperhelper/scrapercontroller.go:213
go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).startScraping.func1
go.opentelemetry.io/collector/[email protected]/scraperhelper/scrapercontroller.go:192

Additional context

This may have been left out deliberately for some reason I can't see. It looks like it may have been an oversight, however.

The relevant line in the snmp receiver that lacks counter64 support.

The gosnmp const.

[github-actions]

Pinging code owners:

• receiver/snmp: @djaglowski @StefanKurek @tamir-michaeli

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[technimad-splunk]

Could a solution be to add gosnmp.Counter64 to the line like this:

        case gosnmp.Counter64, gosnmp.Counter32, gosnmp.Gauge32, gosnmp.Uinteger32, gosnmp.TimeTicks, gosnmp.Integer:

?

We cast to an int 64 in the next line anyway:

                value, err := c.toInt64(pdu.Name, pdu.Value)

[djaglowski]

@technimad-splunk, can I assign this to you?

[technimad-splunk]

@djaglowski Ok. I'll give it a go!

[technimad-splunk]

@bobbled with these PR's merged I believe this issue can be closed. Can you agree and close the issue?

[bobbled]

@technimad-splunk, yes thank you!