Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/opampsupervisor] Implement Collector bootstrapping #21071

Closed
Tracked by #24327
evan-bradley opened this issue Apr 19, 2023 · 1 comment · Fixed by #29848
Closed
Tracked by #24327

[cmd/opampsupervisor] Implement Collector bootstrapping #21071

evan-bradley opened this issue Apr 19, 2023 · 1 comment · Fixed by #29848
Assignees
Labels
cmd/opampsupervisor enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed

Comments

@evan-bradley
Copy link
Contributor

Component(s)

No response

Is your feature request related to a problem? Please describe.

The OpAMP Supervisor needs to support handling AgentDescription messages from the Collector to get the Collector's identifying attributes.

Describe the solution you'd like

The Supervisor should start the Collector with a basic config that includes the opamp extension and allows the Collector to send it this information. More details about this process can be found in the design document here.

Describe alternatives you've considered

No response

Additional context

Depends on #16594.

@evan-bradley evan-bradley added the enhancement New feature or request label Apr 19, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jun 19, 2023
@mwear mwear removed the Stale label Jun 21, 2023
@evan-bradley evan-bradley added the never stale Issues marked with this label will be never staled and automatically removed label Jul 17, 2023
@evan-bradley evan-bradley self-assigned this Dec 12, 2023
evan-bradley added a commit that referenced this issue Jan 12, 2024
**Description:**

Utilize the OpAMP extension to get identifying attributes from the
Collector.

A few things I want to call out:
* I moved the Supervisor's various config fragments into separate files
that are embedded into the binary. I think this makes them easier to
edit. I can also move the changes for the existing fragments to a
separate PR if it adds too much to the diff.
* I opted to use the OTLP receiver instead of the filelog receiver
because it is included in both existing upstream distributions and I
expect it is slightly more common. Ideally we should look at other
approaches to solve this.

**Link to tracking Issue:**

Resolves
#21071

**Testing:**

Added an integration test.

---------

Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Evan Bradley <[email protected]>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
…ry#29848)

**Description:**

Utilize the OpAMP extension to get identifying attributes from the
Collector.

A few things I want to call out:
* I moved the Supervisor's various config fragments into separate files
that are embedded into the binary. I think this makes them easier to
edit. I can also move the changes for the existing fragments to a
separate PR if it adds too much to the diff.
* I opted to use the OTLP receiver instead of the filelog receiver
because it is included in both existing upstream distributions and I
expect it is slightly more common. Ideally we should look at other
approaches to solve this.

**Link to tracking Issue:**

Resolves
open-telemetry#21071

**Testing:**

Added an integration test.

---------

Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Evan Bradley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/opampsupervisor enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants