Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/prometheusreceiver] Send receiver name and version with metrics #20902

Closed
paologallinaharbur opened this issue Apr 14, 2023 · 4 comments
Labels
needs triage New item requiring triage receiver/prometheus Prometheus receiver

Comments

@paologallinaharbur
Copy link
Member

Component(s)

receiver/prometheus

Describe the issue you're reporting

The different receivers are currently setting both name and version of the receiver. Thanks to metrics.go.tmpl all receivers do it in the same way:

	ils.Scope().SetName("otelcol/{{ .Name }}")
	ils.Scope().SetVersion(mb.buildInfo.Version)

For example:

            "otel.library.name": "otelcol/vcenterreceiver",
            "otel.library.version": "0.66.0",

On the other hand, the Prometheus receiver does not have such useful functionality.

            "otel.library.name": "",
            "otel.library.version": "",

It would be nice to add it as well in order to identify the metric source and the version of the receiver.

@paologallinaharbur paologallinaharbur added the needs triage New item requiring triage label Apr 14, 2023
@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Apr 14, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mwear
Copy link
Member

mwear commented Apr 14, 2023

I was asking for something similar here: #13615.

@paologallinaharbur
Copy link
Member Author

Nice to know! Maybe it makes sense to close this one in favor of yours, they are quite interchangeable. 😄

@atoulme atoulme changed the title [receiver/prometheusreceiver] Send recevier name and version with metrics [receiver/prometheusreceiver] Send receiver name and version with metrics Apr 17, 2023
@atoulme
Copy link
Contributor

atoulme commented Apr 17, 2023

Closing in favor of #13615.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage New item requiring triage receiver/prometheus Prometheus receiver
Projects
None yet
Development

No branches or pull requests

3 participants