-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/loki] Do not retry permanent errors #18059
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@wiardvanrij would you like to send a PR for this one? |
Sure, I can take a look |
@jpkrohling thx! I was wondering what the release schedule is? We really would appreciate using this change asap as it now can potentially cause a lot of issues. |
We release every two weeks, the next one on Feb 6th: https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/release.md#release-schedule |
closed by #18083 |
Component(s)
exporter/loki
What happened?
Description
Legacy exporter has: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/lokiexporter/legacy_exporter.go#L164
New exporter hasn't: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/lokiexporter/next_exporter.go#L105
This is pretty painful on 400 requests, like
has timestamp too old
= http 400. Which causes a ton of retries.Collector version
latest
Environment information
No response
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: