Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datadogexporter should have an option to submit counter metric as rate to match datadog-agent #17483

Open
hardproblems opened this issue Jan 9, 2023 · 8 comments
Open

datadogexporter should have an option to submit counter metric as rate to match datadog-agent #17483

hardproblems opened this issue Jan 9, 2023 · 8 comments
Assignees
@hardproblems
Labels
data:metrics Metric related issues enhancement New feature or request exporter/datadog Datadog components never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium

Comments

@hardproblems
Copy link
Contributor

hardproblems commented Jan 9, 2023 •
edited
Loading

Component(s)

exporter/datadog

Is your feature request related to a problem? Please describe.

Datadogexporter submits counter types as count, however datadog-agent and veneur submits counters as rate. At Airbnb we use veneur internally to collect statsd and send to Datadog. We're trying to replace veneur with otel-collector. We tried this on a test project and noticed that it flipped the in-app type of all counters from rate to count and impacted dashboards of all projects that emit shared metrics. This means otel-collector cannot drop-in replace an existing agent compatible with datadog-agent without affecting existing sender's metrics queries on counters and impacting all existing dashboards/ monitors.

Describe the solution you'd like

Add a configuration parameter to allow submitting counters as rate to Datadog and configuring the interval for counter (OTLP sum) -> rate conversion.

Describe alternatives you've considered

I considered using deltatorate processor to convert counters to rate but it converts sum to gauge which would still not be submitted properly.

Additional context

@KSerrania @mx-psi @gbbr @knusbaum @amenasria @dineshg13
@hardproblems hardproblems added enhancement New feature or request needs triage New item requiring triage labels Jan 9, 2023
@hardproblems hardproblems changed the title datadogexporter submission type for counter metric should match that of datadog-agent datadogexporter should have an option to use submission type for counter metric that match datadog-agent Jan 9, 2023
@hardproblems hardproblems changed the title datadogexporter should have an option to use submission type for counter metric that match datadog-agent datadogexporter should have an option to submit counter metric as rate to match datadog-agent Jan 9, 2023
@mx-psi mx-psi added priority:p2 Medium exporter/datadog Datadog components data:metrics Metric related issues labels Jan 10, 2023
@hardproblems hardproblems mentioned this issue Jan 11, 2023
Closed
@atoulme atoulme removed the needs triage New item requiring triage label Mar 10, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 10, 2023
@mx-psi mx-psi removed the Stale label May 10, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 10, 2023
@mx-psi mx-psi removed the Stale label Jul 10, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 11, 2023
@mx-psi mx-psi removed the Stale label Sep 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 13, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2024
@mx-psi mx-psi reopened this Jan 18, 2024
@mx-psi mx-psi added never stale Issues marked with this label will be never staled and automatically removed and removed closed as inactive Stale labels Jan 18, 2024
@mx-psi
Copy link
Member

mx-psi commented Jan 18, 2024

Reopening, we have not addressed this and don't have concrete plans to share here but this is still a valid feature request to consider.

@zekai-rai
Copy link

@mx-psi , is there any recommended workaround for this problem?

@mx-psi mx-psi mentioned this issue Jun 3, 2024
Merged
@jdheyburn
Copy link

jdheyburn commented Sep 3, 2024 •
edited
Loading

I raised the below PR for telegraf datadog output plugin to be able to rate counts when rate_interval: 10s is defined in the config. I'm sure we can do something similar for datadogexporter here too.

I'm trying to understand the context of this PR which changed rates to be counts. cc @mx-psi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hardproblems hardproblems

Labels
data:metrics Metric related issues enhancement New feature or request exporter/datadog Datadog components never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@atoulme @hardproblems @mx-psi @jdheyburn @zekai-rai