Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal/scrapertest] Add traces support #17414

Closed
Tracked by #17544
dmitryax opened this issue Jan 6, 2023 · 1 comment · Fixed by #17443
Closed
Tracked by #17544

[internal/scrapertest] Add traces support #17414

dmitryax opened this issue Jan 6, 2023 · 1 comment · Fixed by #17443
Assignees
@fatsheep9146
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed internal/comparetest priority:p2 Medium

Comments

@dmitryax
Copy link
Member

dmitryax commented Jan 6, 2023 •
edited
Loading

The scrapertest package contains functions for comparing metrics and logs only

We should also extend this package to include similar functions for traces (ReadTraces, WriteTrace, and CompareTraces).
@dmitryax dmitryax added enhancement New feature or request needs triage New item requiring triage help wanted Extra attention is needed good first issue Good for newcomers priority:p2 Medium internal/comparetest and removed needs triage New item requiring triage labels Jan 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Pinging code owners for internal/comparetest: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@fatsheep9146 fatsheep9146 mentioned this issue Jan 9, 2023
Merged
@fatsheep9146 fatsheep9146 self-assigned this Jan 9, 2023
@fatsheep9146 fatsheep9146 mentioned this issue Jan 12, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatsheep9146 fatsheep9146

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed internal/comparetest priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support compare traces in comparetest fatsheep9146/opentelemetry-collector-contrib
2 participants
@dmitryax @fatsheep9146