You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
... for a PR I have already created. The description below is a copy of the PR description. The PR is here: #13864
Description: I have changed the XRay SQL segment translator to send the span name as the 'XRay segment URL' instead of the connection string. This is because in my opinion it is a lot more useful to see this information in the Xray UI (example screenshots below).
Describe the issue you're reporting
This is a placeholder Issue
... for a PR I have already created. The description below is a copy of the PR description. The PR is here: #13864
Description: I have changed the XRay SQL segment translator to send the span name as the 'XRay segment URL' instead of the connection string. This is because in my opinion it is a lot more useful to see this information in the Xray UI (example screenshots below).
I know that this goes against the AWS OTel docs for how particular attributes are translated, as well as the XRay docs for what information goes into the fields for SQL segments. So I'm looking for input from AWS and OTel contributors.
XRay segments UI before this change:
XRay segments UI after this change:
Link to tracking Issue:
Testing: I've updated the tests in awsxrayexporter, and made sure they pass locally.
Documentation: I don't think there is any repo documentation that needs to be changed. But if this change goes through then https://aws-otel.github.io/docs/getting-started/x-ray/#otel-span-sql-attributes-translation might need to be updated.
The text was updated successfully, but these errors were encountered: