Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awsxrayexporter] RFC: SQL segments should use span name for 'url' #14342

Closed
jcmackie opened this issue Sep 21, 2022 · 2 comments
Closed
Assignees
Labels

Comments

@jcmackie
Copy link
Contributor

Describe the issue you're reporting

This is a placeholder Issue

... for a PR I have already created. The description below is a copy of the PR description. The PR is here: #13864

Description: I have changed the XRay SQL segment translator to send the span name as the 'XRay segment URL' instead of the connection string. This is because in my opinion it is a lot more useful to see this information in the Xray UI (example screenshots below).

I know that this goes against the AWS OTel docs for how particular attributes are translated, as well as the XRay docs for what information goes into the fields for SQL segments. So I'm looking for input from AWS and OTel contributors.

XRay segments UI before this change:
Screen Shot 2022-09-03 at 7 33 44 pm

XRay segments UI after this change:
Screen Shot 2022-09-04 at 5 40 19 pm

Link to tracking Issue:

Testing: I've updated the tests in awsxrayexporter, and made sure they pass locally.

Documentation: I don't think there is any repo documentation that needs to be changed. But if this change goes through then https://aws-otel.github.io/docs/getting-started/x-ray/#otel-span-sql-attributes-translation might need to be updated.

@github-actions
Copy link
Contributor

Pinging code owners: @willarmiros. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jcmackie
Copy link
Contributor Author

The PR has been merged now so I'm going to close this issue.
Thanks @evan-bradley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants