Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/tailsampling] SpanCount sampler makes incorrect decision on high volume of spans #13865

Closed
Symbianx opened this issue Sep 5, 2022 · 0 comments · Fixed by #13386
Closed
Labels
bug Something isn't working processor/tailsampling Tail sampling processor

Comments

@Symbianx
Copy link
Contributor

Symbianx commented Sep 5, 2022

Describe the bug
Sometimes, the SpanCount sampler makes the incorrect decision even though there's many spans coming in for the same trace id. This is more likely to happen when there's a high volume of spans and traces coming in to the processor.

After looking at the code, it seems this might be caused by the internal batching behaviour of the processor.

What version did you use?
v0.54.0

What config did you use?

processors:
  tail_sampling:
    decision_wait: 10s
    num_traces: 100
    expected_new_traces_per_sec: 10
    policies:
      [
          {
            name: test-policy-8,
            type: span_count,
            span_count: {min_spans: 2}
          }
      ]

Environment
Docker image
OS: Alpine
Compiler(if manually compiled): go 1.18.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working processor/tailsampling Tail sampling processor
Projects
None yet
2 participants