Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/translator/prometheus] __ in metric name becomes _ #13322

Closed
newly12 opened this issue Aug 15, 2022 · 0 comments · Fixed by #13431
Closed

[pkg/translator/prometheus] __ in metric name becomes _ #13322

newly12 opened this issue Aug 15, 2022 · 0 comments · Fixed by #13431
Assignees
Labels
bug Something isn't working pkg/translator priority:p2 Medium

Comments

@newly12
Copy link
Contributor

newly12 commented Aug 15, 2022

Describe the bug
metric envoy__rule_engine_zlib_buf_error becomes envoy_rule_engine_zlib_buf_error after prometheus translator

Steps to reproduce
in this test, add following and execute

	require.Equal(t, "envoy__rule_engine_zlib_buf_error", CleanUpString("envoy__rule_engine_zlib_buf_error"))
        	Error:      	Not equal: 
        	            	expected: "envoy__rule_engine_zlib_buf_error"
        	            	actual  : "envoy_rule_engine_zlib_buf_error"

What did you expect to see?
envoy__rule_engine_zlib_buf_error

What did you see instead?
envoy_rule_engine_zlib_buf_error

What version did you use?
Version: latest commit

What config did you use?
Config: (e.g. the yaml config file)

Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg/translator priority:p2 Medium
Projects
None yet
2 participants