Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Test - windows-msi #10113

Closed
djaglowski opened this issue May 17, 2022 · 8 comments
Closed

Flaky Test - windows-msi #10113

djaglowski opened this issue May 17, 2022 · 8 comments
Labels
bug Something isn't working closed as inactive flaky test a test is flaky help wanted Extra attention is needed priority:p2 Medium Stale

Comments

@djaglowski
Copy link
Member

This check fails frequently, without much information. Example.

Run .\internal\buildscripts\packaging\msi\make.ps1 Confirm-MSI
  .\internal\buildscripts\packaging\msi\make.ps1 Confirm-MSI
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    TEST_RESULTS: testbed/tests/results/junit/results.xml
Error: The operation was canceled.

As far as I can tell, the operation is not typically canceled intentionally. Possibly it is due to a resource being reallocated, but otherwise this would appear to be a bug.


I would like to re-establish whether we actually want to have this check at all. We do not currently produce an MSI in the releases repo. @open-telemetry/collector-contrib-approvers, any opinions on whether this check is really necessary?

@djaglowski djaglowski added the bug Something isn't working label May 17, 2022
@dmitryax dmitryax added help wanted Extra attention is needed flaky test a test is flaky labels May 20, 2022
@dmitryax
Copy link
Member

dmitryax commented May 20, 2022

I think this test is important enough to have. It verifies the full cycle of collector service on Windows. It may be a bug in the make.ps1 script that should be fixed.

Can we skip the test for now as we did we other flaky tests?

@djaglowski
Copy link
Member Author

Seems reasonable. I'll open a new PR that skips the job.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 8, 2022
@dmitryax dmitryax removed the Stale label Jan 17, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label May 22, 2023
@dmitryax dmitryax removed the Stale label May 22, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jul 24, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2023
@pjanotti
Copy link
Contributor

Notice that core repo currently has a test to validate the collector running as a Windows service, see open-telemetry/opentelemetry-collector#9726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closed as inactive flaky test a test is flaky help wanted Extra attention is needed priority:p2 Medium Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants