Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializing metrics exporter #527

Open
LikeTheSalad opened this issue Aug 12, 2024 · 2 comments
Open

Initializing metrics exporter #527

LikeTheSalad opened this issue Aug 12, 2024 · 2 comments
Labels
v1.0.0-required This is required to reach v1.0.0 (stability)

Comments

@LikeTheSalad
Copy link
Contributor

We're currently initializing tracer and logger rexporters but there's no metrics exporter provided by default, nor there is an "exporter customizer" for metrics either.

@LikeTheSalad LikeTheSalad added the v1.0.0-required This is required to reach v1.0.0 (stability) label Aug 12, 2024
@breedx-splk
Copy link
Contributor

Do we want to even export metrics from mobile clients at all? We've discussed the cardinality and aggregation problems at length...

Even if we do choose to add this, I'm not sure that I would consider it a requirement for v1.0.0.

@LikeTheSalad
Copy link
Contributor Author

We do not want to export metrics ourselves, though I don't think it's safe to assume that our preferences are shared by every user of this library.

Also, I believe one important aspect of a library is its behavior predictability and API consistency. Since we are already doing the exporter setup for 2 out of the 3 signal types of OTel, it seems strange that we just leave one out. Likewise for the APIs that allow to customize them.

The above is mainly the reason why I believe this should be a requirement for v1.0.0. Although I guess to be more specific, the requirement I think is more about making all signals behave the same way, though that doesn't mean that we must initialize a metric exporter, I guess another approach could be not initializing any exporter at all and provide setters for each instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.0.0-required This is required to reach v1.0.0 (stability)
Projects
None yet
Development

No branches or pull requests

2 participants