We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think the "proper" solution would be to switch from legacy `# type:` comments to using actual annotations.
For example, instead of:
mandatory_keys = ("id", "brief") # type: Tuple[str, ...]
use:
mandatory_keys: Tuple[str, ...] = ("id", "brief")
And since we probably rely on 3.9+ anyway, one could even use the built-in tuple support for generic arguments and drop the import, using:
tuple
import
mandatory_keys: tuple[str, ...] = ("id", "brief")
Not a blocking comment, just a suggestion.
Originally posted by @Oberon00 in #231 (comment)
The text was updated successfully, but these errors were encountered:
Given that we're sunsetting build-tools (#322) and it's not applicable to weaver, I'm going to close it
Sorry, something went wrong.
No branches or pull requests
For example, instead of:
use:
And since we probably rely on 3.9+ anyway, one could even use the built-in
tuple
support for generic arguments and drop theimport
, using:Not a blocking comment, just a suggestion.
Originally posted by @Oberon00 in #231 (comment)
The text was updated successfully, but these errors were encountered: