Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support referencing attributes across signals in codegen #155

Closed
lmolkova opened this issue Mar 7, 2023 · 1 comment
Closed

Support referencing attributes across signals in codegen #155

lmolkova opened this issue Mar 7, 2023 · 1 comment

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Mar 7, 2023

See open-telemetry/opentelemetry-specification#3299.
E.g. user_agent.original is defined within attribute_group in opentelemetry-specification/semantic_conventions folder and referenced in resource semconv here https://github.com/open-telemetry/opentelemetry-specification/blob/main/semantic_conventions/resource/browser.yaml

Code generator allows to specify source folder and would generate all semconv from there, applying --only or --exclude flags to the source. It uses the same subset of files to resolve attributes and generate code for them.

When browser resource semconv is generated, we need to use all resource + cross-signal attributes to resolve attributes, but generate only those that are in resource. there is no such option today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant