add "allowHexadecimal" reader option #1510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyDonahue
requested changes
Dec 27, 2023
| else if (c >= '0') | ||
| c -= '0'; | ||
| else | ||
| return addError("Contains non-hexadecimal digits.", token, current); |
There was a problem hiding this comment.
seems that this wouldn't catch nonhex characters like 'z'.
There was a problem hiding this comment.
Hmm... I think I had assumed that token.start/token.end were being set correctly by readHexadecimal(). It would make the method more robust and flexible to check both bounds though. Will fix.
|
Closing this due to inactivity. Feel free to reopen if you are able to address feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional read-support for hexadecimal numbers matching
0x[0-9a-fA-F]{1,16}(size depends on LargestUInt). New capability is tied to the allowHexadecimal reader-option.Not sure if there is much interest aside from myself. This would contribute to possible future JSON5 support which does seem to have been considered (#209 #723). Would need to support leading
(+|-)for this to be compliant with the JSON5 spec.